Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: java unit tests now run check not test #31226

Closed
wants to merge 2 commits into from

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Oct 10, 2023

What

Fixes an issue where unit tests failed as python3.9 was installed

Related slack thread

How

This was because we were trying to run python formatters.

The solution is to not run these, or any check, but only run unit tests as gradle check is run at the top level on any PR already

@bnchrch bnchrch requested review from postamar, alafanechere and a team October 10, 2023 18:42
@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2023 6:44pm

@bnchrch
Copy link
Contributor Author

bnchrch commented Oct 10, 2023

@bnchrch bnchrch marked this pull request as draft October 10, 2023 18:51
@bnchrch bnchrch removed the request for review from a team October 10, 2023 18:51
@bnchrch bnchrch marked this pull request as ready for review October 10, 2023 19:17
@bnchrch
Copy link
Contributor Author

bnchrch commented Oct 10, 2023

Closing in favor of #31227

@bnchrch bnchrch closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant