-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA checks] tolerate connector without dockerfile #30467
[QA checks] tolerate connector without dockerfile #30467
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
2aef971
to
41ce5f5
Compare
001d411
to
43049f0
Compare
f9bea4b
to
b608d76
Compare
43049f0
to
2690638
Compare
) | ||
|
||
|
||
def get_qa_checks_to_run(connector: Connector) -> Tuple[Callable]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
b608d76
to
10448cc
Compare
2690638
to
5938a15
Compare
10448cc
to
72b1de6
Compare
5938a15
to
b83cb4d
Compare
72b1de6
to
3fffee5
Compare
b83cb4d
to
9029852
Compare
3fffee5
to
0a60854
Compare
9029852
to
e6bcea4
Compare
0a60854
to
94f6f82
Compare
d66bece
to
d067ece
Compare
return None | ||
|
||
@property | ||
def version(self) -> str: | ||
def version(self) -> Optional[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this one optional? I get becuase self.version_in_dockerfile_label
could now be None
- but shouldn't we error out if we can't retrieve a version for the connector?
96068a5
to
18693fc
Compare
d067ece
to
d8731ed
Compare
source-faker test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-faker docker image for platform(s) linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-faker | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-faker test
destination-duckdb test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build destination-duckdb docker image for platform(s) linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for destination-duckdb | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-duckdb test
6456ed2
to
183eef5
Compare
74800ab
to
6f77a7a
Compare
6f77a7a
to
98c98e3
Compare
source-auth0 test report (commit
|
Step | Result |
---|---|
Connector package install | ✅ |
Build source-auth0 docker image for platform(s) linux/x86_64 | ✅ |
Acceptance tests | ✅ |
Code format checks | ✅ |
Validate metadata for source-auth0 | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-auth0 test
What
Now that it's OK that a connector does not have a Dockerfile our QA checks should tolerate it.
How
has_dockerfile
property on theConnector
utility class