Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors-ci: disable dependency scanning #29033

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix docstring
  • Loading branch information
alafanechere committed Aug 3, 2023
commit d92fa1a2f1fca9392e5f824a608436815268bf06
4 changes: 2 additions & 2 deletions airbyte-ci/connectors/pipelines/pipelines/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,8 @@ def _find_modified_connectors(

def get_modified_connectors(modified_files: Set[Path], all_connectors: Set[Connector], dependency_scanning: bool) -> Set[Connector]:
"""Create a mapping of modified connectors (key) and modified files (value).
If dependency scanning is enable any modification to a dependency will trigger connector pipeline for all connectors that depend on it.
It currently works for Java connectors only.
If dependency scanning is enabled any modification to a dependency will trigger connector pipeline for all connectors that depend on it.
It currently works only for Java connectors .
It's especially useful to trigger tests of strict-encrypt variant when a change is made to the base connector.
Or to tests all jdbc connectors when a change is made to source-jdbc or base-java.
We'll consider extending the dependency resolution to Python connectors once we confirm that it's needed and feasible in term of scale.
Expand Down