connectors-ci: skipped status when metadata upload exits with 5 #28938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#28767 changed how we identify steps as skipped.
The exit code that leads to the "skipped" step status is now defined at the
Step
subclass level and is not global.It introduced a regression for the MetadataUpload step - when its container exits with 5 it means the upload was skipped because the metadata yaml already exists on the bucket.
How
Declare in
MetadataUpload
that the skipped exit code is 5