Revert "Helm: set new attribute (#22114)" #22801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 39402c1.
Airbyte Code Coverage
|
tkorenko
approved these changes
Feb 10, 2023
|
@xpuska513 is preparing a fix but in the meantime we'll rollback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 39402c1.
What
Revert bad Helm change.
That PR introduced a '-' in a value name, which isn't allowed.
Example failing run: https://github.com/airbytehq/airbyte/actions/runs/4143579215/jobs/7165614852
Some background context: helm/helm#2192
Issue reported: #22699
How
git revert 39402c1664ae88f33f273e631388f3a6b6ae35cf