-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use launchdarkly feature flagging for column selection #22577
use launchdarkly feature flagging for column selection #22577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 as long as syncInput.getWorkspaceId()
doesn't return null
...src/main/java/io/airbyte/container_orchestrator/orchestrator/ReplicationJobOrchestrator.java
Show resolved
Hide resolved
airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/ReplicationActivityImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Also the feature flagging looks much less complicated with the new client - nice!
Airbyte Code Coverage
|
Some notes:
All in all I'm very confident that the change is safe, and also pretty confident that it works as intended, so I'll go ahead here. |
What
Use LaunchDarkly feature-flagging for column selection.
How
Check whether column selection should be enabled for the workspace against the feature flag client (LaunchDarkly).
This PR will always return
no
for now, so this is effectively a no-op. Then we can update the rules in LaunchDarkly as we see fit. Once we're happy with those, we can stop reading (and eventually remove) the various environment variables that are in use today.Testing
To validate this change, I did the following: (1) deployed to dev-3; (2) disabled column selection per the various old env variable flags; (3) enabled in LD; (4) verified via logs that column selection was being applied in the backend.