-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused test utils #22464
remove unused test utils #22464
Conversation
/test connector=connectors/destination-postgres
Build PassedTest summary info:
|
Airbyte Code Coverage
|
@@ -1,21 +0,0 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the related gradle task as well.
https://github.com/airbytehq/airbyte/blob/master/build.gradle#L374
and https://github.com/airbytehq/airbyte/blob/master/build.gradle#L387
as well as the tags name: https://github.com/airbytehq/airbyte/blob/master/build.gradle#L341
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should remove more (in the build.yml file)
* wip; rem unused code * change visibibility of helper classes; move test code to usage sites * replace SchemaTableNamePair with record class * rename io.airbyte.test.airbyte_test_container -> io.airbyte.test.container * pr-feedback; remove references to deleted annotations * remove deprecated gh actions
What
How
@IntegrationTest
@SlowIntegrationTest
io.airbyte.test.airbyte_test_container
->io.airbyte.test.container
CockroachDBContainerHelper
public
modifier fromGKEPostgresConfig
PostgresSQLContainerHelper
functions toPostgresDestintationTest
SchemaTableNamePair
class withrecord