Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused test utils #22464

Merged
merged 11 commits into from
Feb 7, 2023
Merged

remove unused test utils #22464

merged 11 commits into from
Feb 7, 2023

Conversation

colesnodgrass
Copy link
Member

What

  • cleanup test-utils code
  • remove unused code
  • move code to be closer to usage

How

  • remove unused annotations
    • @IntegrationTest
    • @SlowIntegrationTest
  • rename pakage io.airbyte.test.airbyte_test_container -> io.airbyte.test.container
  • remove unused CockroachDBContainerHelper
  • remove public modifier from GKEPostgresConfig
  • move PostgresSQLContainerHelper functions to PostgresDestintationTest
  • replace SchemaTableNamePair class with record

@colesnodgrass colesnodgrass requested a review from a team as a code owner February 7, 2023 00:06
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 7, 2023 00:08 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 7, 2023 00:08 — with GitHub Actions Inactive
@gosusnp
Copy link
Contributor

gosusnp commented Feb 7, 2023

/test connector=connectors/destination-postgres

🕑 connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/4109152336
✅ connectors/destination-postgres https://github.com/airbytehq/airbyte/actions/runs/4109152336
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Airbyte Code Coverage

File Coverage [0%]
AirbyteTestContainer.java 0%
PostgreSQLContainerHelper.java 0%
SchemaTableNamePair.java 0%
GKEPostgresConfig.java 0%
AirbyteAcceptanceTestHarness.java 0%
Total Project Coverage 24.56%

@@ -1,21 +0,0 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@benmoriceau benmoriceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove more (in the build.yml file)

@colesnodgrass colesnodgrass requested a review from a team as a code owner February 7, 2023 17:55
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 7, 2023 17:57 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 7, 2023 18:09 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 7, 2023 18:09 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 7, 2023 18:36 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 7, 2023 18:36 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass merged commit 2385175 into master Feb 7, 2023
@colesnodgrass colesnodgrass deleted the cole/rm-unused-test-utils branch February 7, 2023 19:33
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
* wip; rem unused code

* change visibibility of helper classes; move test code to usage sites

* replace SchemaTableNamePair with record class

* rename io.airbyte.test.airbyte_test_container -> io.airbyte.test.container

* pr-feedback; remove references to deleted annotations

* remove deprecated gh actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants