-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Airtable: fix cases with empty result
while discover the schema
#22245
Conversation
/test connector=connectors/source-airtable
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -89,17 +91,22 @@ def get_json_schema(table: Dict[str, Any]) -> Dict[str, str]: | |||
name: str = SchemaHelpers.clean_name(field.get("name")) | |||
original_type: str = field.get("type") | |||
options: Dict = field.get("options", {}) | |||
exec_type: str = options.get("result", {}).get("type") if options else None | |||
field_type: str = exec_type if exec_type else original_type | |||
options_result: Dict = options.get("result", {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need an if options else None
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept that to ensure options: null
case is covered, just in case)
Just got paged for this - publishing now. |
/publish connector=airbyte/source-airtable
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-airtable
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Airbyte Code Coverage
|
What
Resolving: https://github.com/airbytehq/oncall/issues/1432
How
result
object could beNull
, which means we should fallback tostring
type🚨 User Impact 🚨
No impact is expected. Just fixing the blocker.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here