Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature-flag and socat envvars to allowed set #22185

Merged
merged 2 commits into from
Feb 1, 2023
Merged

add feature-flag and socat envvars to allowed set #22185

merged 2 commits into from
Feb 1, 2023

Conversation

colesnodgrass
Copy link
Member

@colesnodgrass colesnodgrass commented Feb 1, 2023 •
edited
Loading

What

  • add feature-flag envvars to allowed list
  • add socat envvars to allowed list

TODO

  • in follow-up PR sort the ENV_VARS_TO_TRANSFER set to make it easier to read

@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 00:17 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 00:17 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 00:19 — with GitHub Actions Inactive
@colesnodgrass colesnodgrass temporarily deployed to more-secrets February 1, 2023 00:20 — with GitHub Actions Inactive
@davinchia davinchia merged commit 96b70bc into master Feb 1, 2023
@davinchia davinchia deleted the cole/add-orchestrator-envvars branch February 1, 2023 00:21
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023 •
edited
Loading

Airbyte Code Coverage

File Coverage [38.91%] ❌
EnvConfigs.java 45.75% ❌
OrchestratorConstants.java 0% ❌
Total Project Coverage 24.51% ❌

@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
This was referenced Feb 8, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesnodgrass @davinchia