Rename source acceptance test to connector acceptance test #21846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected Connector ReportNOTE
|
| Connector | Version | Changelog | Publish |
|---|---|---|---|
source-airtable |
2.0.2 |
✅ | ✅ |
source-alloydb |
1.0.36 |
✅ | ✅ |
source-alloydb-strict-encrypt |
1.0.36 |
🔵 (ignored) |
🔵 (ignored) |
source-amazon-ads |
0.1.29 |
✅ | ✅ |
source-amazon-seller-partner |
0.2.31 |
✅ | ✅ |
source-amazon-sqs |
0.1.0 |
✅ | ✅ |
source-amplitude |
0.1.21 |
✅ | ✅ |
source-appsflyer |
0.1.0 |
✅ | ✅ |
source-asana |
0.1.5 |
✅ | ✅ |
source-azure-table |
0.1.3 |
✅ | ✅ |
source-bigquery |
0.2.3 |
✅ | ✅ |
source-braintree |
0.1.3 |
✅ | ✅ |
source-cart |
0.2.0 |
✅ | ✅ |
source-chargebee |
0.1.16 |
✅ | ✅ |
source-clickhouse |
0.1.15 |
✅ | ✅ |
source-clickhouse-strict-encrypt |
0.1.15 |
🔵 (ignored) |
🔵 (ignored) |
source-cockroachdb |
0.1.19 |
✅ | ✅ |
source-cockroachdb-strict-encrypt |
0.1.19 |
🔵 (ignored) |
🔵 (ignored) |
source-commercetools |
0.1.0 |
✅ | ✅ |
source-confluence |
0.1.1 |
✅ | ✅ |
source-datadog |
0.1.0 |
✅ | ✅ |
source-db2 |
0.1.17 |
✅ | ✅ |
source-db2-strict-encrypt |
0.1.17 |
🔵 (ignored) |
🔵 (ignored) |
source-delighted |
0.2.0 |
✅ | ✅ |
source-drift |
0.2.5 |
✅ | ✅ |
source-elasticsearch |
0.1.1 |
✅ | ✅ |
source-facebook-marketing |
0.2.84 |
✅ | ✅ |
source-freshcaller |
0.1.0 |
✅ | ✅ |
source-freshsales |
0.1.2 |
✅ | ✅ |
source-freshservice |
0.1.1 |
✅ | ✅ |
source-github |
0.4.1 |
✅ | ✅ |
source-gitlab |
1.0.2 |
✅ | ✅ |
source-google-ads |
0.2.9 |
✅ | ✅ |
source-google-search-console |
0.1.19 |
✅ | ✅ |
source-greenhouse |
0.3.0 |
✅ | ✅ |
source-harvest |
0.1.15 |
✅ | ✅ |
source-instagram |
1.0.1 |
✅ | ✅ |
source-iterable |
0.1.23 |
✅ | ✅ |
source-kafka |
0.2.3 |
✅ | ✅ |
source-klaviyo |
0.1.11 |
✅ | ✅ |
source-lemlist |
0.1.1 |
✅ | ✅ |
source-lever-hiring |
0.1.3 |
✅ | ✅ |
source-linnworks |
0.1.5 |
✅ | ✅ |
source-mailchimp |
0.3.2 |
✅ | ✅ |
source-mailgun |
0.1.0 |
✅ | ✅ |
source-monday |
0.2.2 |
✅ | ✅ |
source-mongodb-strict-encrypt |
0.1.19 |
🔵 (ignored) |
🔵 (ignored) |
source-mongodb-v2 |
0.1.19 |
✅ | ✅ |
source-mssql |
0.4.28 |
✅ | ✅ |
source-mssql-strict-encrypt |
0.4.28 |
🔵 (ignored) |
🔵 (ignored) |
source-mysql |
1.0.21 |
✅ | ✅ |
source-mysql-strict-encrypt |
1.0.21 |
🔵 (ignored) |
🔵 (ignored) |
source-notion |
1.0.1 |
✅ | ✅ |
source-okta |
0.1.14 |
✅ | ✅ |
source-onesignal |
0.1.2 |
✅ | ✅ |
source-openweather |
0.1.6 |
✅ | ✅ |
source-oracle |
0.3.22 |
✅ | ✅ |
source-oracle-strict-encrypt |
0.3.22 |
🔵 (ignored) |
🔵 (ignored) |
source-outreach |
0.1.2 |
✅ | ✅ |
source-pardot |
0.1.1 |
✅ | ✅ |
source-paystack |
0.1.1 |
✅ | ✅ |
source-pinterest |
0.2.2 |
✅ | ✅ |
source-pipedrive |
0.1.13 |
✅ | ✅ |
source-plaid |
0.3.2 |
✅ | ✅ |
source-postgres |
1.0.42 |
✅ | ✅ |
source-postgres-strict-encrypt |
1.0.42 |
🔵 (ignored) |
🔵 (ignored) |
source-posthog |
0.1.8 |
✅ | ✅ |
source-prestashop |
0.3.0 |
✅ | ✅ |
source-quickbooks-singer |
0.1.5 |
✅ | ✅ |
source-recharge |
0.2.5 |
✅ | ✅ |
source-redshift |
0.3.16 |
✅ | ✅ |
source-retently |
0.1.3 |
✅ | ✅ |
source-salesforce |
1.0.30 |
✅ | ✅ |
source-salesloft |
0.1.3 |
✅ | ✅ |
source-scaffold-java-jdbc |
0.1.0 |
🔵 (ignored) |
🔵 (ignored) |
source-sendgrid |
0.3.1 |
✅ | ✅ |
source-sentry |
0.1.10 |
✅ | ✅ |
source-sftp |
0.1.2 |
✅ | ✅ |
source-snowflake |
0.1.29 |
✅ | ✅ |
source-strava |
0.1.2 |
✅ | ✅ |
source-surveymonkey |
0.1.14 |
✅ | ✅ |
source-tidb |
0.2.2 |
✅ | ✅ |
source-tplcentral |
0.1.1 |
✅ | ✅ |
source-twilio |
0.1.15 |
✅ | ✅ |
source-weatherstack |
0.1.0 |
✅ | ✅ |
source-youtube-analytics |
0.1.3 |
✅ | ✅ |
source-zendesk-sunshine |
0.1.1 |
✅ | ✅ |
source-zendesk-talk |
0.1.6 |
✅ | ✅ |
source-zenloop |
0.1.4 |
✅ | ✅ |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (0)
| Connector | Version | Changelog | Publish |
|---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
| Category | Status | Actionable Item |
|---|---|---|
| Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
| ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
| Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
| ❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
| Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
| ❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
Airbyte Code Coverage
|
|
/test connector=connectors/source-google-ads
Build PassedTest summary info: |
|
/test connector=connectors/source-google-analytics-v4
Build PassedTest summary info: |
|
/test connector=connectors/source-google-sheets
Build PassedTest summary info: |
|
/test connector=connectors/source-greenhouse
Build PassedTest summary info: |
|
/test connector=connectors/source-harvest
Build PassedTest summary info: |
|
/test connector=connectors/source-intercom
Build PassedTest summary info: |
|
/test connector=connectors/source-mailchimp
Build PassedTest summary info: |
|
/test connector=connectors/source-marketo
Build PassedTest summary info: |
|
/test connector=connectors/source-mixpanel
|
|
/test connector=connectors/source-postgres
Build PassedTest summary info: |
|
/test connector=connectors/source-recharge
Build PassedTest summary info: |
|
/test connector=connectors/source-notion
Build PassedTest summary info: |
|
/publish connector=bases/connector-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
|
/test connector=connectors/source-file
Build PassedTest summary info: |
This was referenced Feb 8, 2023
sh4sh
added a commit
to StevenReitsma/airbyte
that referenced
this pull request
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #21382
This PR renames the SATs to simply (connector) acceptance tests. The "connector" prefix can be dropped in descriptions if there is no ambiguity. This is done to make it clear that parts of the provided test suites (the spec-related tests) are general enough to also be used for destinations. In a separate step these will be rolled out for existing destinations.
The general way of configuring tests via the
acceptance-test-config.ymldoesn't change.Note: Originally I wanted to remove the
connector-prefix in more places, but there are places where I would strongly prefer it (e.g. in the name of the docker image to make clear what it is about or the gradle plugin as there are also kubernetes acceptance tests at the moment) and it seemed weird to me to switch the naming over in some place so I stuck with it in most places for now (e.g. name of the python package).How
airebyte/connector-acceptance-testswill start with the same version as the existing one to ease migration. Existing references to the old image will still work, they just won't receive upgrades anymore. (it's not published yet, I will do this once this PR is approved)yarn && yarn build && yarn servein thedocusaurusdirectoryHow to review
airbyte-integrations/bases- renamesource-acceptance-testdirectoryairbyte-integrations/connector-templates- reference new docker image / gradle taskairbyte-integrations/connectorsdocsyarn && yarn build && yarn servein thedocusaurusdirectorybuildSrcrename gradle plugin and make it use the new imagesettings.gradlechange name of task for building acceptance tests themselvestoolsrename references