Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment auto detect schema #21731

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Uncomment auto detect schema #21731

merged 4 commits into from
Jan 23, 2023

Conversation

alovew
Copy link
Contributor

@alovew alovew commented Jan 23, 2023

JobsConfig is removed from ConfigFetchActivityImpl, so auto detect schema can be turned back on

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Jan 23, 2023
@alovew alovew temporarily deployed to more-secrets January 23, 2023 18:11 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 23, 2023 18:11 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 23, 2023 18:29 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 23, 2023 18:29 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Airbyte Code Coverage

File Coverage [63.39%] 🍏
SyncWorkflowImpl.java 89.31% 🍏
ActivityBeanFactory.java 0% ❌
Total Project Coverage 26.7% 🍏

@alovew alovew temporarily deployed to more-secrets January 23, 2023 19:08 — with GitHub Actions Inactive
@alovew alovew temporarily deployed to more-secrets January 23, 2023 19:08 — with GitHub Actions Inactive
jdpgrailsdev
jdpgrailsdev approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alovew alovew enabled auto-merge (squash) January 23, 2023 19:30
@alovew alovew merged commit 1fba39a into master Jan 23, 2023
@alovew alovew deleted the anne/turn-on-auto-detect-schema branch January 23, 2023 19:41
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@benmoriceau benmoriceau Awaiting requested review from benmoriceau

@gosusnp gosusnp Awaiting requested review from gosusnp

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alovew @jdpgrailsdev @octavia-squidington-iv