Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor copy change to fcp modal #21681

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Minor copy change to fcp modal #21681

merged 1 commit into from
Jan 21, 2023

Conversation

andyjih
Copy link
Contributor

@andyjih andyjih commented Jan 20, 2023

Just a quick copy change.

@andyjih andyjih requested a review from ambirdsall January 20, 2023 23:01
@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Jan 20, 2023
Copy link
Contributor

@ambirdsall ambirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now than it was before, thanks! 👍

"freeConnectorProgram.enrollmentModal.free": "<p1>Alpha and Beta Connectors are free while you're in the program.</p1><p2>The whole Connection is free until both Connectors have move into General Availability (GA)</p2>",
"freeConnectorProgram.enrollmentModal.emailNotification": "We will let you know through email before a Connector you use moves to GA",
"freeConnectorProgram.enrollmentModal.free": "<p1>Alpha and Beta Connectors are free while you're in the program.</p1><p2>The whole Connection is free until both Connectors have moved into General Availability (GA)</p2>",
"freeConnectorProgram.enrollmentModal.emailNotification": "We will email you before both connectors in a connection move to GA.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too bad every alternate phrasing I've considered (e.g. "before the last alpha or beta connector in a connection moves to GA") reads more awkwardly that this; I'm just pedantic enough to want to pick at the "both... move" nit 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Words are hard 😅

@andyjih andyjih merged commit 0548d5f into master Jan 21, 2023
@andyjih andyjih deleted the fcp-copy-change branch January 21, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants