Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency declared twice #21628

Merged
merged 2 commits into from
Jan 20, 2023
Merged

remove dependency declared twice #21628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db59df
remove dependency declared twice
colesnodgrass Jan 19, 2023
7bfc04a
remove dependency declared twice
colesnodgrass Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion airbyte-integrations/bases/standard-destination-test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ dependencies {
implementation project(':airbyte-json-validation')
implementation project(':airbyte-integrations:bases:base-java')
implementation project(':airbyte-protocol:protocol-models')
implementation project(':airbyte-commons-worker')

implementation(enforcedPlatform('org.junit:junit-bom:5.8.2'))
implementation 'org.junit.jupiter:junit-jupiter-api'
Expand Down
12 changes: 6 additions & 6 deletions airbyte-integrations/bases/standard-source-test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ dependencies {
implementation project(':airbyte-config:config-models')
implementation project(':airbyte-config:config-persistence')
implementation project(':airbyte-protocol:protocol-models')
implementation project(':airbyte-commons-worker')
implementation 'org.mockito:mockito-core:4.6.1'

implementation 'net.sourceforge.argparse4j:argparse4j:0.8.1'
Expand All @@ -30,7 +29,7 @@ dependencies {

def getFullPath(String className) {
def matchingFiles = project.fileTree("src/main/java")
.filter { file -> file.getName().equals("${className}.java".toString())}.asCollection()
.filter { file -> file.getName().equals("${className}.java".toString()) }.asCollection()
if (matchingFiles.size() == 0) {
throw new IllegalArgumentException("Ambiguous class name ${className}: no file found.")
}
Expand All @@ -51,14 +50,15 @@ task generateSourceTestDocs(type: Javadoc) {
destinationDir = javadocOutputDir

doLast {
def className = "SourceAcceptanceTest" // this can be made into a list once we have multiple standard tests, and can also be used for destinations
def className = "SourceAcceptanceTest"
// this can be made into a list once we have multiple standard tests, and can also be used for destinations
def pathInPackage = getFullPath(className)
def stdSrcTest = project.file("${javadocOutputDir}/${pathInPackage}.html").readLines().join("\n")
def methodList = Jsoup.parse(stdSrcTest).body().select("section.methodDetails>ul>li>section")
def md = ""
for (methodInfo in methodList){
for (methodInfo in methodList) {
def annotations = methodInfo.select(".memberSignature>.annotations").text()
if (!annotations.contains("@Test")){
if (!annotations.contains("@Test")) {
continue
}
def methodName = methodInfo.selectFirst("div>span.memberName").text()
Expand All @@ -73,7 +73,7 @@ task generateSourceTestDocs(type: Javadoc) {
outputDoc.append md
}

outputs.upToDateWhen {false}
outputs.upToDateWhen { false }
}

project.build.dependsOn(generateSourceTestDocs)
Expand Down