Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Improve database sources & destinations error messages #11322

Closed
Tracked by #12322 ...
sherifnada opened this issue Mar 22, 2022 · 7 comments
Closed
Tracked by #12322 ...

[EPIC] Improve database sources & destinations error messages #11322

sherifnada opened this issue Mar 22, 2022 · 7 comments

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

When users are setting up a database connector and fail (due to misconfiguration) they are often provided a non-descriptive error message like the following:
image

This causes drop off in activation when users are trying out Airbyte. We'd like to make these error messages more descriptive as they can greatly increase the usage of Airbyte.

Describe the solution you’d like

I would like these error messages to be much more descriptive in the following connectors (ordered by priority):
Sources:

  • Postgres
  • MySQL
  • MSSQL
  • Snowflake
  • Mongo
  • File source
  • Oracle

Destinations:

  • Redshift
  • GCS
  • MySQL
  • Postgres
  • Mongo

I imagine the best way to achieve this:

  1. Induce as many configuration failures as we can think of in test cases
  2. Identify which error messages returned by the database correspond to which errors
  3. Return helpful error messages from the check method to help the user understand the action they can take to fix the problem
  4. Write test cases to ensure that these error messages are always helpful to the user

Some error cases we can run into (this is not comprehensive, just the ones I can think of right now):

  • Wrong password (but correct everything else)
  • Wrong username (but correct everything else)
  • Wrong host (but correct everything else)
  • Wrong port (but correct everything else)
  • Wrong database name (but correct everything else)
  • No permissions on the selected schema/DB/table
  • Any other incorrect / incompatible settings
@tuliren
Copy link
Contributor

tuliren commented Apr 22, 2022

More examples can be found in this slack thread.

@grishick
Copy link
Contributor

grishick commented May 2, 2022

The fix should probably use the new AirbyteTraceMessage that is being added to the protocol: #12458

@Phlair
Copy link
Contributor

Phlair commented May 3, 2022

@grishick I'm currently working on this to create AirbyteTraceMessage functionality for Java connectors, after which it can be used to create the improved errors as per this issue.

Had an idea for some incremental value here by doing this: https://github.com/airbytehq/airbyte-internal-issues/issues/601
We looked at it in backlog grooming and think that jdbc ticket likely fits better in dbs & dws connector team, just fyi.

@mkhokh-33
Copy link
Contributor

mkhokh-33 commented May 9, 2022

@Phlair, @grishick, @alexandr-shegeda

We had a look on trace messages documentation and we don't have clear understanding where and how this trace messages functionality should be applied in scope of this task.

We are working in scope of this epic with error messages marked on screenshot as section 2

2022-05-09_16-16

So we are trying to map returned errors into user friendly error messages.
From documentation we see screenshots for log section with preview which we currently do not have

2022-05-09_16-05

Could you please provide understanding what should be done in scope of trace messages functionality for this epic and UI mock ups how it should look ?

Thus we don't have clear understanding of trace messages role in scope of this ticket we propose to finish this epic without trace messages implementation and create and estimate new task for it, cause this changes might include some UI tasks as well.

Thanks

@alexandr-shegeda
Copy link
Contributor

PR is already available for review here

@grishick
Copy link
Contributor

Are this ticker and PR still active?

@mkhokh-33
Copy link
Contributor

yes, will merge last updates form master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Implementation in progress
Development

Successfully merging a pull request may close this issue.

10 participants