Skip to content

Commit

Permalink
Remove source and destination definition calls that were used only to…
Browse files Browse the repository at this point in the history
… get the icon. (#21608)
  • Loading branch information
krishnaglick authored Jan 19, 2023
1 parent af5843a commit 95f2c45
Showing 1 changed file with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import { NextTable } from "components/ui/NextTable";
import { SyncSchemaField, SyncSchemaFieldObject } from "core/domain/catalog";
import { AirbyteStreamConfiguration } from "core/request/AirbyteClient";
import { useConnectionFormService } from "hooks/services/ConnectionForm/ConnectionFormService";
import { useDestinationDefinition } from "services/connector/DestinationDefinitionService";
import { useSourceDefinition } from "services/connector/SourceDefinitionService";
import { equal } from "utils/objects";
import { getDataType } from "utils/useTranslateDataType";

Expand Down Expand Up @@ -59,8 +57,6 @@ export const StreamFieldsTable: React.FC<StreamFieldsTableProps> = ({
const {
connection: { source, destination },
} = useConnectionFormService();
const sourceDefinition = useSourceDefinition(source.sourceDefinitionId);
const destinationDefinition = useDestinationDefinition(destination.destinationDefinitionId);

// prepare data for table
const tableData: TableStream[] = useMemo(
Expand Down Expand Up @@ -163,7 +159,7 @@ export const StreamFieldsTable: React.FC<StreamFieldsTableProps> = ({
() => [
columnHelper.group({
id: "source",
header: () => <ConnectorHeaderGroupIcon type="source" icon={sourceDefinition.icon} />,
header: () => <ConnectorHeaderGroupIcon type="source" icon={source.icon} />,
columns: sourceColumns,
meta: {
thClassName: styles.headerGroupCell,
Expand All @@ -188,15 +184,15 @@ export const StreamFieldsTable: React.FC<StreamFieldsTableProps> = ({
}),
columnHelper.group({
id: "destination",
header: () => <ConnectorHeaderGroupIcon type="destination" icon={destinationDefinition.icon} />,
header: () => <ConnectorHeaderGroupIcon type="destination" icon={destination.icon} />,
columns: destinationColumns,
meta: {
thClassName: styles.headerGroupCell,
tdClassName: styles.bodyCell,
},
}),
],
[columnHelper, destinationColumns, destinationDefinition.icon, sourceColumns, sourceDefinition.icon]
[columnHelper, destination.icon, destinationColumns, source.icon, sourceColumns]
);

return <NextTable<TableStream> columns={columns} data={tableData} className={styles.customTableStyle} />;
Expand Down

0 comments on commit 95f2c45

Please sign in to comment.