Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
alafanechere committed Jul 30, 2024
1 parent 043b832 commit 675b165
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def connector_context(dagger_client):
@pytest.mark.parametrize("use_local_cdk", [True, False])
async def test_apply_python_development_overrides(connector_context, use_local_cdk):
connector_context.use_local_cdk = use_local_cdk
fake_connector_container = connector_context.dagger_client.container().from_("airbyte/python-connector-base:1.0.0")
fake_connector_container = connector_context.dagger_client.container().from_("airbyte/python-connector-base:2.0.0")
before_override_pip_freeze = await fake_connector_container.with_exec(["pip", "freeze"]).stdout()

assert "airbyte-cdk" not in before_override_pip_freeze.splitlines(), "The base image should not have the airbyte-cdk installed."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ def latest_cdk_version():
def python_connector_with_setup_not_latest_cdk(all_connectors):
for connector in all_connectors:
if (
connector.metadata.get("connectorBuildOptions", {}).get("baseImage", False)
connector.metadata.get("connectorBuildOptions", False)
# We want to select a connector with a base image version >= 2.0.0 to use Python 3.10
and not connector.metadata.get("connectorBuildOptions", {})
.get("baseImage", "")
.startswith("docker.io/airbyte/python-connector-base:1.")
and connector.language == "python"
and connector.code_directory.joinpath("setup.py").exists()
):
Expand Down

0 comments on commit 675b165

Please sign in to comment.