Enable high strictness level (#21618)

airbytehq · Jan 23, 2023 · 2a71464 · 2a71464
1 parent 3b1864f
commit 2a71464
Show file tree

Hide file tree

Showing 4 changed files with 145 additions and 32 deletions.
diff --git a/airbyte-integrations/connectors/source-zendesk-talk/README.md b/airbyte-integrations/connectors/source-zendesk-talk/README.md
@@ -49,15 +49,15 @@ and place them into `secrets/config.json`.
 python main.py spec
 python main.py check --config secrets/config.json
 python main.py discover --config secrets/config.json
-python main.py read --config secrets/config.json --catalog sample_files/configured_catalog.json
+python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json
 ```
 
 ### Locally running the connector docker image
 
 #### Build
 First, make sure you build the latest Docker image:
 ```
-docker build . -t airbyte/zendesk-talk:dev
+docker build . -t airbyte/source-zendesk-talk:dev 
 ```
 
 You can also build the connector image via Gradle:
@@ -79,7 +79,7 @@ docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/sample_files:/sample_files
    Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
 First install test dependencies into your virtual environment:
 ```
-pip install .[tests]
+pip install .'[tests]'
 ```
 ### Unit Tests
 To run unit tests locally, from the connector directory run:

diff --git a/airbyte-integrations/connectors/source-zendesk-talk/acceptance-test-config.yml b/airbyte-integrations/connectors/source-zendesk-talk/acceptance-test-config.yml
@@ -2,32 +2,52 @@
 # for more information about how to configure these tests
 # intentionally left out explicit configured_catalog.json to test all streams from discovery
 connector_image: airbyte/source-zendesk-talk:dev
-tests:
+test_strictness_level: "high"
+acceptance_tests:
   spec:
-    - spec_path: "source_zendesk_talk/spec.json"
+    tests:
+      - spec_path: "source_zendesk_talk/spec.json"
   connection:
-    - config_path: "secrets/config.json"
-      status: "succeed"
-    - config_path: "integration_tests/invalid_config.json"
-      status: "failed"
-    - config_path: "secrets/config_old.json"
-      status: "succeed"
+    tests:
+      - config_path: "secrets/config.json"
+        status: "succeed"
+      - config_path: "integration_tests/invalid_config.json"
+        status: "failed"
+      - config_path: "secrets/config_old.json"
+        status: "succeed"
   discovery:
-    - config_path: "secrets/config.json"
-      backward_compatibility_tests_config:
-        disable_for_version: "0.1.3"
-    - config_path: "secrets/config_old.json"
-      backward_compatibility_tests_config:
-        disable_for_version: "0.1.3"
+    tests:
+      - config_path: "secrets/config.json"
+        backward_compatibility_tests_config:
+          disable_for_version: "0.1.3"
+      - config_path: "secrets/config_old.json"
+        backward_compatibility_tests_config:
+          disable_for_version: "0.1.3"
   basic_read:
-    - config_path: "secrets/config.json"
+    tests:
+      - config_path: "secrets/config.json"
+        expect_records:
+          path: "integration_tests/expected_records.jsonl"
+          extra_fields: no
+          exact_order: no
+          extra_records: yes
+        empty_streams:
+          - name: "account_overview"
+            bypass_reason: "The objects can mutate quite often."
+          - name: "agents_overview"
+            bypass_reason: "The objects can mutate quite often."
+          - name: "current_queue_activity"
+            bypass_reason: "The objects can mutate quite often."
   incremental:
-    - config_path: "secrets/config.json"
-      future_state_path: "integration_tests/abnormal_state.json"
+    tests:
+      - config_path: "secrets/config.json"
+        future_state:
+          future_state_path: "integration_tests/abnormal_state.json"
   full_refresh:
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/configured_catalog.json"
-      ignored_fields:
-        account_overview: ["current_timestamp"]
-        agents_overview: ["current_timestamp"]
-        current_queue_activity: ["current_timestamp"]
+    tests:
+      - config_path: "secrets/config.json"
+        configured_catalog_path: "integration_tests/configured_catalog.json"
+        ignored_fields:
+          account_overview: ["current_timestamp"]
+          agents_overview: ["current_timestamp"]
+          current_queue_activity: ["current_timestamp"]
diff --git a/airbyte-integrations/connectors/source-zendesk-talk/integration_tests/abnormal_state.json b/airbyte-integrations/connectors/source-zendesk-talk/integration_tests/abnormal_state.json
@@ -1,8 +1,20 @@
-{
-  "calls": {
-    "updated_at": "2121-01-01T00:00:00Z"
+[
+  {
+    "type": "STREAM",
+    "stream": {
+      "stream_state": {
+        "updated_at": "2121-01-01T00:00:00Z"
+      },
+      "stream_descriptor": { "name": "calls" }
+    }
   },
-  "call_legs": {
-    "updated_at": "2121-01-01T00:00:00Z"
+  {
+    "type": "STREAM",
+    "stream": {
+      "stream_state": {
+        "updated_at": "2121-01-01T00:00:00Z"
+      },
+      "stream_descriptor": { "name": "call_legs" }
+    }
   }
-}
+]