change link file name

airbytehq · Feb 22, 2024 · 1bcd36f · 1bcd36f
1 parent 23c2512
commit 1bcd36f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/templates/test_report.html.j2 b/...ectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/templates/test_report.html.j2
@@ -171,7 +171,7 @@ function copyToClipBoard(htmlElement) {
       <h3>Artifacts</h3>
       <ul>
       {% for artifact in step_result_to_artifact_links[step_result.step.title] %}
-        <li><a href="{{ artifact.url }}" download="{{ artifact.name }}">{{ artifact.name }}</a></li>
+        <li><a href="{{ artifact.url }}" download>{{ artifact.name }}</a></li>
       {% endfor %}
       </ul>
       {% endif %}

diff --git a/airbyte-ci/connectors/pipelines/pipelines/models/artifacts.py b/airbyte-ci/connectors/pipelines/pipelines/models/artifacts.py
@@ -29,7 +29,7 @@ async def save_to_local_path(self, path: Path) -> Path:
             raise Exception(f"Failed to save artifact {self.name} to local path {path}")
 
     async def upload_to_gcs(self, dagger_client: dagger.Client, bucket: str, key: str, gcs_credentials: dagger.Secret) -> str:
-        gcs_cp_flags = [f"--content-disposition=attachment;filename='{self.name}'"]
+        gcs_cp_flags = [f'--content-disposition=filename="{self.name}"']
         if self.content_type is not None:
             gcs_cp_flags = gcs_cp_flags + [f"--content-type={self.content_type}"]