[Java CDK] : Remove isHeartbeatSupported() from target position inter…

…face
airbytehq · Feb 20, 2024 · 0ea8b41 · 0ea8b41
1 parent 40a5edc
commit 0ea8b41
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 16 deletions.
diff --git a/...-cdk/db-sources/src/main/java/io/airbyte/cdk/integrations/debezium/CdcTargetPosition.java b/...-cdk/db-sources/src/main/java/io/airbyte/cdk/integrations/debezium/CdcTargetPosition.java
@@ -36,15 +36,6 @@ default boolean reachedTargetPosition(final T positionFromHeartbeat) {
     throw new UnsupportedOperationException();
   }
 
-  /**
-   * Indicates whether the implementation supports heartbeat position.
-   *
-   * @return true if heartbeats are supported
-   */
-  default boolean isHeartbeatSupported() {
-    return false;
-  }
-
   /**
    * Returns a position value from a heartbeat event offset.
    *

diff --git a/.../src/main/java/io/airbyte/cdk/integrations/debezium/internals/DebeziumRecordIterator.java b/.../src/main/java/io/airbyte/cdk/integrations/debezium/internals/DebeziumRecordIterator.java
@@ -189,7 +189,7 @@ public void close() throws Exception {
   }
 
   private boolean isHeartbeatEvent(final ChangeEvent<String, String> event) {
-    return targetPosition.isHeartbeatSupported() && Objects.nonNull(event) && !event.value().contains("source");
+    return Objects.nonNull(event) && !event.value().contains("source");
   }
 
   private boolean heartbeatPosNotChanging() {

diff --git a/airbyte-integrations/connectors/source-postgres/build.gradle b/airbyte-integrations/connectors/source-postgres/build.gradle
@@ -14,7 +14,7 @@ java {
 airbyteJavaConnector {
     cdkVersionRequired = '0.20.6'
     features = ['db-sources', 'datastore-postgres']
-    useLocalCdk = false
+    useLocalCdk = true
 }
 
 application {

diff --git a/.../src/main/java/io/airbyte/integrations/source/postgres/cdc/PostgresCdcTargetPosition.java b/.../src/main/java/io/airbyte/integrations/source/postgres/cdc/PostgresCdcTargetPosition.java
@@ -87,11 +87,6 @@ private PgLsn extractLsn(final JsonNode valueAsJson) {
         .orElseThrow(() -> new IllegalStateException("Could not find LSN"));
   }
 
-  @Override
-  public boolean isHeartbeatSupported() {
-    return true;
-  }
-
   @Override
   public Long extractPositionFromHeartbeatOffset(final Map<String, ?> sourceOffset) {
     return (long) sourceOffset.get("lsn");