Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IncrementingCountCursor #346

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

artem1205
Copy link
Contributor

@artem1205 artem1205 commented Feb 18, 2025

What

add IncrementingCountCursor

How

Warning

A known and expected issue with this stub is running a check with the declared IncrementingCountCursor because it is run without ConcurrentCursor.

@github-actions github-actions bot added the enhancement New feature or request label Feb 18, 2025
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Feb 19, 2025
@artem1205
Copy link
Contributor Author

artem1205 commented Feb 21, 2025

UPD:

found an interesting bug:
concurrentcursor is used only during the read, if we'll run check command on stream with the IncrementingCountCursor we'll face a bug.

we need to implement IncrementingCountCursor to make it pass

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
…g_count_cursor

# Conflicts:
#	airbyte_cdk/sources/declarative/concurrent_declarative_source.py
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants