Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add min macros #203

Merged
merged 3 commits into from
Jan 7, 2025
Merged

feat: add min macros #203

merged 3 commits into from
Jan 7, 2025

Conversation

artem1205
Copy link
Contributor

@artem1205 artem1205 commented Jan 7, 2025 •
edited by coderabbitai bot
Loading

What

add new macros to interpolation: min function

Summary by CodeRabbit

Release Notes

  • New Features
    • Added min function to support finding the minimum value in Jinja template interpolations.
  • Tests
    • Expanded test coverage for the new min function with multiple test scenarios.
    • Added test to verify macro availability.

@artem1205
CDK: add min macros
17a2bce 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205
CDK: add unit tests
7eaa17f 
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Jan 7, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 7, 2025
@artem1205 artem1205 marked this pull request as ready for review January 7, 2025 17:36
@artem1205 artem1205 requested a review from maxi297 January 7, 2025 17:36
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request introduces a new min macro function to the Airbyte CDK's declarative source interpolation system. This addition enables users to find the minimum value in Jinja templates, complementing the existing max function. The change involves implementing the min function in the macros module and adding corresponding test cases to verify its functionality across different input scenarios.

Changes

File Change Summary
airbyte_cdk/sources/declarative/interpolation/macros.py Added min function to macro list, supporting minimum value selection
unit_tests/sources/declarative/interpolation/test_jinja.py Added parameterized test cases for min function with various input types
unit_tests/sources/declarative/interpolation/test_macros.py Added test case to check macro export for "min"

Sequence Diagram

sequenceDiagram
    participant Jinja as Jinja Template
    participant Macros as Macro Functions
    participant MinFunc as Min Function

    Jinja->>Macros: Request min value
    Macros->>MinFunc: Call min function
    MinFunc-->>Macros: Return smallest value
    Macros-->>Jinja: Provide minimum result
Loading

Hey there! 👋 Quick question - did you notice that the test case in test_macros.py seems to have a small inconsistency? The test is labeled "test_min" but checks for the "max" function. Might want to double-check that, wdyt?

The implementation looks solid overall - adding the min function provides a nice symmetry with the existing max function. The test coverage looks comprehensive, testing different input scenarios like single arguments and lists. Nice work! 🚀

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7eaa17f and f16ab95.

📒 Files selected for processing (1)
  • unit_tests/sources/declarative/interpolation/test_macros.py (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • unit_tests/sources/declarative/interpolation/test_macros.py
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Analyze (python)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
unit_tests/sources/declarative/interpolation/test_jinja.py (1)

187-187: Test coverage looks good! Consider adding edge cases?

The tests cover the basic functionality well. Would you consider adding tests for edge cases? For example:

  • Empty list handling
  • Mixed type comparisons
  • Single argument case
    wdyt?

Also applies to: 295-296

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 884897e and 7eaa17f.

📒 Files selected for processing (3)
  • airbyte_cdk/sources/declarative/interpolation/macros.py (2 hunks)
  • unit_tests/sources/declarative/interpolation/test_jinja.py (2 hunks)
  • unit_tests/sources/declarative/interpolation/test_macros.py (1 hunks)
🔇 Additional comments (2)
airbyte_cdk/sources/declarative/interpolation/macros.py (2)

97-114: LGTM! Clean implementation of the min function

The implementation mirrors the max function, has comprehensive documentation, and correctly uses Python's built-in min function.

170-170: LGTM! Correctly registered in _macros_list

@artem1205 @coderabbitai
Update unit_tests/sources/declarative/interpolation/test_macros.py
f16ab95 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
maxi297
maxi297 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artem1205 artem1205 merged commit 3ee710d into main Jan 7, 2025
16 of 20 checks passed
@artem1205 artem1205 deleted the artem1205/add-min-macros branch January 7, 2025 18:48
rpopov added a commit to rpopov/airbyte-python-cdk that referenced this pull request Jan 8, 2025
@rpopov
Merge branch 'main' into 50395-1-2
b2dab7b 
* main:
  fix(airbyte-cdk): unable to create custom retriever (airbytehq#198)
  feat(low-code): added keys replace transformation (airbytehq#183)
  feat: add `min` macros (airbytehq#203)
  fix(low-code cdk pagination): Fix the offset strategy so that it resets back to 0 when a stream is an incremental data feed (airbytehq#202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@artem1205 artem1205

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artem1205 @maxi297