Skip to content

Commit

Permalink
Fix RequestOptionsProvider for PerPartitionWithGlobalCursor
Browse files Browse the repository at this point in the history
  • Loading branch information
tolik0 committed Jan 23, 2025
1 parent 4459243 commit 4444893
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -2374,7 +2374,7 @@ def create_simple_retriever(
if (
not isinstance(stream_slicer, DatetimeBasedCursor)
or type(stream_slicer) is not DatetimeBasedCursor
) and not isinstance(stream_slicer, PerPartitionWithGlobalCursor):
):
# Many of the custom component implementations of DatetimeBasedCursor override get_request_params() (or other methods).
# Because we're decoupling RequestOptionsProvider from the Cursor, custom components will eventually need to reimplement
# their own RequestOptionsProvider. However, right now the existing StreamSlicer/Cursor still can act as the SimpleRetriever's
Expand Down

0 comments on commit 4444893

Please sign in to comment.