Keep track of version in library #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please write in commit message the new version number, it is hard to guess. |
dbarbier
reviewed
Nov 8, 2021
utils/collect_env.py
Outdated
| @@ -18,6 +18,12 @@ | |||
| except (ImportError, NameError, AttributeError, OSError): | |||
| TORCH_AVAILABLE = False | |||
|
|
|||
| try: | |||
| from skdecide import __version__ | |||
There was a problem hiding this comment.
You could write
try:
from skdecide import __version__ as skdecide_version
except (ImportError):
skdecide_version = "not available"and use skdecide_version directly
- vx.y.z.dev{{distance}}+{{sha}} for dev release
dbarbier
approved these changes
Nov 9, 2021
dbarbier
added a commit
to dbarbier/scikit-decide
that referenced
this pull request
Nov 9, 2021
The only open pull request which modifies files under skdecide/ directory is airbus#98, conflict resolution will be trivial, so we can apply pre-commit linters. There is no code change, this commit only contains changes performed by running pre-commit run -a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
skdecide/__iniy__.pyutils/collect_env.pyis called