Unify usage of domain_factory in API #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2465a30 to
41f46c0
Compare
- C++ solvers need the domain_factory in their __init__ - Some other solvers needed it during solve and thus it was introduced in Domain.solve_with() and Solver.solve() and even in Restorable.load() Here we unify this by putting all these domain_factory in all solvers __init__. During __init__ we take care to autocast the domain_factory so that it produced the domain at the appropriate level for the solver (at is was previously done in solve() which then called _solve()). We thus avoid repeating this process twice (it was done also in load()) and improve the readibility for users (that sometime needed to put domain_factory in __init__, sometimes in solve_with)
fteicht
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we unify this by putting all these domain_factory in all solvers init.
During init we take care to autocast the domain_factory so that it produced the domain at the appropriate level for the solver (at is was previously done in solve() which then called _solve()). We thus avoid repeating this process twice (it was done also in load()) and improve the readibility for users (that sometime needed to put domain_factory in init, sometimes in solve_with)