Integrate binder environment in development branches instead of a separate dedicated orphan branch #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b12c6b3 to
7b9d951
Compare
|
I tried the workflows on my own fork:
|
7b9d951 to
ce5e119
Compare
- create reusable workflows to share between release.yml and build.yml - update actions to make them use node 20 (node 18 being deprecated) - upload-artifact and download-artifact @v4 are using immutable artifacts sor we need to upload wheels to separate artifacts But we can still download them all to update the nightly wheel by using `pattern` + `merge_multiple` - in case of push on master, we do not need anymore to push on binder branch, and master binder env defined in subdirectory binder/ will install last "nightly" wheel available - in case of release, we do not push anymore to binder branch but rather update the subdirectory binder/ and push it in the same tag created for colab notebooks - to ensure having last "nightly" wheel correspond to the state of master branch, we trigger the job "upload-nightly" for each push on master (not waiting for following night), and make deploy-doc depends on it so that the binder env built by deploy-doc will get the proper version of scikit-decide - the scheduled workflows are nno more necessary to have an up-to-date wheel on "nightly" release but rather only to check that dependencies are not messing up the library => we schedule only once a week from now
We update the python script generating the notebooks doc page with binder links. We also integrate some improvements robustifying it: - strip first line before extracting title of notebooks - allow notebooks in subdirectories and creating subsections according to the arborescence
ce5e119 to
cc6820d
Compare
fteicht
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way the binder environment will follow the code modifications without having to push on binder orphan branch.
We still install the scikit-decide last nightly build when building the binder env. The environment corresponding to master branch
will be rebuilt each time nightly build is triggered
modified to install the latest release when launched on colab