Remove Solver intermediate private methods not to be overriden
#321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convention is the library is that the user has to override/implement methods whose names are starting with "_". The methods wihtout the leading "_" are calling the former, generally by adding autocast boilerplate. In Solver class, some methods are duplicated without this purpose in mind, we simplify it here: - _get_domain_requirements() -> get_domain_requirements() - _check_domain -> check_domain(), which continue calling _check_domain_additional() to be overriden - _solve() -> solve(), and _solve_domain() -> _solve(), so that solve() autocast domain_factory and then call _solve() to be implemented
26602ef to
f12f092
Compare
fteicht
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention is the library is that the user has to override/implement
methods whose names are starting with "_".
The methods wihtout the leading "_" are calling the former, generally by
adding autocast boilerplate.
In Solver class, some methods are duplicated without this purpose in
mind, we simplify it here:
_get_domain_requirements()->get_domain_requirements()_check_domain()->check_domain(), which continue calling_check_domain_additional()to be overriden_solve()->solve(), and_solve_domain()->_solve(), so thatsolve()autocastdomain_factoryand then call_solve()to be implemented