Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build wheels for macosx-arm64 #303

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Build wheels for macosx-arm64 #303

merged 5 commits into from
Jan 9, 2024

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Jan 2, 2024 •
edited
Loading

We adapt the workflow used by scikit-learn (see this workflow and this script).

  • We cross-compile from macosx-x86_64 (the only macosx github runner available).
  • We use cibuildwheel to create the wheel, with the appropriate flags.
  • We use a suitable version of openmp, taken from conda-forge and adapted to scipy.
  • We remove the dependency up-tamer when not on x86_64 as no wheel suitable in this case

Warnings:

  • The version of openmp used here is 11.1.0 (until now, brew was installing 17.0.6).
  • The arm64 wheel is not tested later in the workflow as no github runner exists with macosx-amr64 platform.

@nhuet nhuet force-pushed the macosx-arm64 branch 2 times, most recently from 6e25a3f to 2f474f1 Compare January 2, 2024 17:25
@fteicht fteicht self-assigned this Jan 9, 2024
@fteicht fteicht self-requested a review January 9, 2024 09:04
@fteicht fteicht added the enhancement New feature or request label Jan 9, 2024
fteicht
fteicht approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@fteicht fteicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @nhuet !

nhuet added 5 commits January 9, 2024 11:13
@nhuet
Build wheels for macosx_arm64
f0ab544 
We cross-compile from macosx_x86_64 (only macosx github runner
available).

We adapt the workflow used by scikit-learn (see
https://github.com/scikit-learn/scikit-learn/blob/main/build_tools/wheels/build_wheels.sh)

We use cibuildwheel to create the wheel, with the appropriate flags.

NB: the arm64 wheel is not tested later in the workflow as no github
runner exists with macosx_amr64 platform.
@nhuet
Use the proper version of openmp according to platform and architecture
70e11ed 
We follow scikit-learn and use a suitable version of openmp according to
the architecture, taken from conda-forge and adapted to scipy.

Be careful that the version used is 11.1.0 (until now, brew was
installing 17.0.6)
@nhuet
Apply macosx-arm64 wheel build to releases also
ff193c6
@nhuet
Add comment in full_multisolve.py about packages needed.
df3cb0b
@nhuet
Install up-tamer only on x86_64 machines
506c2c2
@nhuet
Copy link
Contributor Author

nhuet commented Jan 9, 2024

I solved the merge conflict @fteicht

@fteicht fteicht merged commit b10e1ec into airbus:master Jan 9, 2024
42 checks passed
@nhuet nhuet mentioned this pull request Jan 12, 2024
Closed
@nhuet nhuet deleted the macosx-arm64 branch April 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fteicht fteicht fteicht approved these changes

Assignees

@fteicht fteicht

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhuet @fteicht