Use importlib.metadata instead of pkg_resources to manage entry points #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0db82b4 to
971bf06
Compare
- reason 1: in colab, we need to reload some packages via importlib.reload which messes with pkg_resources - reason 2: the use of pkg_resources is deprecated in favor of importlib. See warning in https://setuptools.pypa.io/en/latest/pkg_resources.html We test the modified functions in test_utils.py NB: the behaviour and nature of importlib.metadata.entry_points() is different for python <3.10 and >=3.10
971bf06 to
a86bac3
Compare
The import of c++ library is failing for an unknown reason only on github runner. This is during an import of Astar solver inside the domain module (which could also raise a philosophical issue about a domain from hub needing a solver from hub, whereas dependencies for domains and solvers are separated into 2 extras.
a86bac3 to
570d399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We test the modified functions in test_utils.py