Call pytest on all tests #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c1f4dc to
82aa02b
Compare
Instead of calling explicitely pytest on each subdirectory of tests/, we call it directly on tests/ which will recursively look for any subdirectory. Because of the previous strategy, we missed domains/ and flight_planning/ subdirectories.
- For tests, we need gymnasium[classic-control] => added to
dev-dependencies + install it together with pytest in github actions
NB: we do it at the same time as installing scikit-decide wheel to be
sure to have the proper version of gymnasium
- When IPython is not available, skip the function clear_output() as it
is only for notebooks
- For flight planning, we need cartopy and pygrib dependencies:
- add to dependencies installed with "domain" and "all" extras
- do not install pygrib if on windows (does not exists)
- do not install cartopy if on python<3.9 (no wheel, generates
install issues)
- skip tests for flight-planning if on windows or python<3.9
g-poveda
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling explicitely pytest on each subdirectory of tests/, we call it directly on tests/ which will recursively look for any subdirectory.
Because of the previous strategy, we missed domains/ and flight_planning/ subdirectories.