Add a method add_agents() to all multiagents domain + fix paper-rock-scissors multiagent domain #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for instance by mahd solver. It mirrors ray.rllib API (which has get_agent_ids() in their multiagent environments)
neo-alex
reviewed
Nov 28, 2023
tests/autocast/test_agent.py
Outdated
| # single agent domain | ||
| domain = MyDomain() | ||
|
|
||
| # up-casted as multi-agent domain |
There was a problem hiding this comment.
I believe that the past/passive form of cast is "cast" (not "casted)
tests/autocast/test_agent.py
Outdated
| domain = MyDomain() | ||
|
|
||
| # up-casted as multi-agent domain | ||
| domainupcasted = MyDomain() |
There was a problem hiding this comment.
... so maybe upcast_domain instead (cf. previous comment)?
Must return a dict for termination attribute of TransitionOutcome
neo-alex
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_agents()is supposed to exist by mahd solver and mirrors rllib api (add_agent_ids())_state_step()was not returning a dictionary inTransitionOutcome.termination