Add --all-files option to pre-commit command to avoid skipping the test #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No tests were actually done by the linter action because `pre-commit
run` look only files in the index by default.
When checkout a whole PR, no files are in the index so no files are
checked.
Previously, the job returned something like
Trim Trailing Whitespace.............................(no files to check)Skipped
Fix End of Files.....................................(no files to check)Skipped
Check Yaml...........................................(no files to check)Skipped
Check for added large files..........................(no files to check)Skipped
Pretty format JSON...................................(no files to check)Skipped
isort (python).......................................(no files to check)Skipped
black................................................(no files to check)Skipped
nbqa-isort...........................................(no files to check)Skipped
nbqa-black...........................................(no files to check)Skipped
nbqa-pycln...........................................(no files to check)Skipped
nbstripout...........................................(no files to check)Skipped
Now the checks are done (and should read as "Passed")
We make a `pre-commit run --all-files` in this commit to have the job
pass.
We also remove the pretty-format-json hook which was tampering with the
notebooks (oddly only remotely on the github runner, not locally on my
laptop), and was not very useful for the repository anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests were actually done by the linter action because
pre-commit runlook only files in the index by default.When checkouting a whole PR, no files are in the index so no files are checked.
Previously, the job returned something like
Now the checks are done (and should read as "Passed")
We make a
pre-commit run --all-filesin this commit to have the job pass.We also remove the pretty-format-json hook which was tampering with the notebooks (oddly only remotely on the github runner, not locally on my laptop), and was not very useful for the repository anyway.