Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preinstall gym==0.21.0 with option --no-use-pep517 #253

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Apr 20, 2023

New versions of pip/setuptools enforce pep 517 by default, which is not respected by gym 0.21.0 install.
So we preinstall with option --no-use-pep517 so that the installation of scikit-decide[all] works.

Note that it could be also nice to upgrade to gymnasium 0.26 and later but this is not yet possible because of a conflict between recent versions of ray[rllib] and stable-baselines3 which are each fixing a different version of gymnasium.

We also add this tip in the documentation to install scikit-decide (normal process and developper mode).

nhuet added 2 commits April 21, 2023 11:52
Indeed, new versions of pip/setuptools enforce pep 517 which is not
respected by gym 0.21.0 install. So we preinstall with option
--no-use-pep517 so that the installation of scikit-decide[all] works.

Note that it could be good to upgrade to gymnasium 0.26 and later but
this is not yet possible because of a conflict between recent versions
of ray[rllib] and stable-baselines3 which are each fixing a different
version of gymnasium.
@nhuet nhuet force-pushed the gym-install branch 2 times, most recently from bab9346 to def05ae Compare April 21, 2023 10:09
Copy link
Collaborator

@g-poveda g-poveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I don't like this kind of fix but we are not responsible right ?!, fine for me

@g-poveda g-poveda requested review from neo-alex and fteicht April 21, 2023 14:24
Copy link
Collaborator

@fteicht fteicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks!

@neo-alex neo-alex merged commit 27ba71d into airbus:master Apr 21, 2023
@nhuet nhuet deleted the gym-install branch June 29, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants