Refresh workflows

[galleon]

Refreshing all actions used in both build and release workflows in prevision of node12 deprecation

[nhuet]

You forgot to bump download-artifact in build.yml version at lines 424, 504, 584, 684, 717 and in release.yml (other lines:)
Be carefule that when using v3, you have also to add path argument when not yet present to make the next steps work:

      - name: Download artifacts
        uses: actions/download-artifact@v3
        with:
          name: wheels
          path: wheels

You could also change JamesIves/github-pages-deploy-action version in build.yml (for v4 as in release.yml) so that:

• it is consistent with release.yml
• more importantly it use the last v4.x.y version, which is now using node 16

Personnally i would rather squash all commit "Advancing..." and add explanation in commit message that it is to get node 16 using actions because of node 12 end of support.

I would like also having a small explanation about why you drop pre-commit action and change the action creating the release. (I know why because I did the same for discrete-optimization but someone else might want to know the reason requiring these changes).

[nhuet]

LGTM

[dbarbier]

There are still many warnings

[nhuet]

There are still many warnings

This is another matter: these warnings (at least those I have seem) are not about node 12, but rather about "set-output command is deprecated". And are actually coming from github actions (maintained by github) for which the version used is already the more recent. For instance, download-artifact@v3 leads to these warnings.

My guess is that github will soon update these actions and that we will have to bump them again at that time.

[dbarbier]

There are still many warnings

This is another matter: these warnings (at least those I have seem) are not about node 12, but rather about "set-output command is deprecated". And are actually coming from github actions (maintained by github) for which the version used is already the more recent. For instance, download-artifact@v3 leads to these warnings.

My guess is that github will soon update these actions and that we will have to bump them again at that time.

No, these warnings come from our workflows, grep "set-output".

[galleon]

The remaining warnings come from actions/download-artifact@v3. There is a PR to update to the latest actions/core that will solve this - not is our hands.

[dbarbier]

IMHO you should check release.yml in your fork

[dbarbier]

You are modifying the contents of these variables without giving any reason; why did you add calls to dumps()?

[dbarbier]

Looks good, but you must explain in the last commit message why you want to merge these changes. You claim that set-output is unsafe, this is not clear to me whether this is true.

[galleon]

Looks good, but you must explain in the last commit message why you want to merge these changes. You claim that set output is unsafe, this is not clear to me whether this is true.
I have used GH comment

[g-poveda]

trust in previous reviews.