Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate step uploading doc to github-pages #215

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Oct 11, 2022

This deployment was made twice when pushing on master. It is better to do it only if all tests pass, so we keep the second instance of the step instead of the first one.

This deployment was made twice when pushing on master.
It is better to do it only if all tests pass, so we keep the second
instance of the step instead of the first one.
Copy link
Contributor

@galleon galleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g-poveda
Copy link
Collaborator

lgtm

@g-poveda g-poveda merged commit 0b4dba0 into airbus:master Oct 12, 2022
@nhuet nhuet deleted the nht/rm_double_deploy_doc branch June 29, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants