Build macos wheel on macos-latest github runner #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galleon
suggested changes
Sep 26, 2022
Macos-10.15 github runner is deprecated and will be removed starting December (cf actions/runner-images#5583). So we need to move the build on macos-latest (= macos-11 currently). We ensure that the resulting wheel is still compatible with macos-10.15.
2d029ac to
1239338
Compare
|
I had to work a bit so that the wheel still works on macos 10.15 (it needs at least to have the proper name). I rebase with the solution i found and let the tests as before (not mentioning **-latest in tests oses) |
|
I also added macos-12 in tests. |
|
Nice! The workflow passed this time! And with the requested changes. |
galleon
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macos-10.15 github runner is deprecated and will be removed starting December (cf actions/runner-images#5583). So we need to move the build on macos-latest (= macos-11 currently) and see if tests still pass on macos-10.15.
The other github runner names are also change for their "$os-latest" aliases when possible to follow more easily the update of github runners.