Add a tasks_full_details attribute to State for scheduling notebook #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the code optimization made on scheduling algorithms in commit b76e15a, the attribute `tasks_details` does not keep track of all tasks anymore. Thus: - we introduce a new attribute `tasks_full_details` which holds also information for non-completed tasks and is actually a property reconstructed on-the-fly via `rebuild_all_tasks_dict` - we add a dummy task for each task id in `rebuild_all_tasks_dict` output so that we can call a task detail even before starting any task as required in the scheduling notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the code optimization made on scheduling algorithms in commit b76e15a, the attribute
tasks_detailsdoes not keep track of all tasks anymore. Thus:tasks_full_detailswhich holds also information for non-completed tasks and is actually a property reconstructed on-the-fly viarebuild_all_tasks_dictrebuild_all_tasks_dictoutput so that we can call a task detail even before starting any task as required in the scheduling notebook