Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite extender to return a list #189

Merged
merged 1 commit into from
May 16, 2022

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Apr 21, 2022

We revert commit 9df73f7 because
returning a generator may lead to errors hard to understand when the
domain developper do not take properly into account how "yield" works,
for instance if using global variables.

But we still modify how the list is computed to avoid using 2
intermediate lists (which allow to gain 1.1 speed factor on a
given graph shortest path example).

We revert commit 9df73f7 because
returning a generator may lead to errors hard to understand when the
domain developper do not take properly into account how "yield" works,
for instance if using global variables.

But we still modify how the list is computed to avoid using 2
intermediate lists (which allow to gain 1.1 speed factor on a
given graph shortest path example).
Copy link
Collaborator

@fteicht fteicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @nhuet !

@fteicht fteicht merged commit ef81ed2 into airbus:master May 16, 2022
@nhuet nhuet deleted the nht/extender-single-list branch September 19, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants