Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 175 #176

Closed
wants to merge 2 commits into from
Closed

Fix issue 175 #176

wants to merge 2 commits into from

Conversation

galleon
Copy link
Contributor

@galleon galleon commented Jan 13, 2022

This commit change the way a Box action is discretized.
It is inspired from the gym.spaces.Box.sample method. For unbounded spaces it builds on the quantile distribution of the Cauchy distribution (using a scale of 1).
An alternative could be derived from the logit function: log(1+p) - log(1-p) for example. But the current implementation has a larger spread.

@galleon galleon requested a review from fteicht January 13, 2022 17:18
@nhuet
Copy link
Contributor

nhuet commented May 30, 2022

Hi. The first commit "Removing need for GH_ACCESS_TOKEN" should not be part of this PR. For the remaining, it seems ok for me but I let more qualified people decide about what the Box space should look like.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants