Fix issue 142 #173
Fix issue 142 #173
Conversation
|
@fteicht Your changes break windows-2016 builds; any chance to have a version which works with any windows-* version? |
|
Yes because I've just figured out that old versions of MSVC (e.g. 2017 and before) cannot correctly parse typedef members inside lambda functions. It was corrected by the introduction of the |
| typedef typename ExecutionPolicy::template atomic<std::size_t> | ||
| atomic_size_t; | ||
| typedef typename ExecutionPolicy::template atomic<double> atomic_double; | ||
| typedef typename ExecutionPolicy::template atomic<bool> atomic_bool; |
There was a problem hiding this comment.
These typedefs appear in public methods, why are they private?
There was a problem hiding this comment.
You're right, I've just committed the change. Thanks!
There was a problem hiding this comment.
Well done, looks good to me.
Since windows-2016 Github runners are going to be removed on March 2022, you should replace windows-2016 by windows-latest on l.40 of build.yml
build = [ "macos-10.15", "ubuntu-latest", "windows-2016" ]
and l. 29 of release.yml
build_dict = { "macos":["macos-10.15"], "ubuntu":["ubuntu-latest"], "windows":["windows-2016"] }
On Windows backward compatibility is ensured, so we can build on -latest.
And bonus points if you squash your commits ;-)
|
@fteicht Please remove the merge commit, it does not provide any value: You can run |
7bf5f70 to
45a5132
Compare
Fix issue #142