Trigger a build of release binder env on mybinder.org #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to reduce the starting time for real users. Indeed, according to the mybinder documentation, the build step occurs only the first time the binderhub launches a jupyter session for a repo with an updated ref. Cf https://mybinder.readthedocs.io/en/latest/about/about.html#what-factors-influence-how-long-it-takes-a-binder-session-to-start We use a script taken from https://github.com/scikit-hep/pyhf/blob/master/binder/trigger_binder.sh to ping the endpoints of each binderhub in the mybinder.org federation. (cf https://mybinder.readthedocs.io/en/latest/about/federation.html)
dbarbier
suggested changes
Dec 13, 2021
.github/workflows/release.yml
Outdated
| @@ -505,6 +505,13 @@ jobs: | |||
| # switch back to original branch | |||
| git checkout $TAG_NAME | |||
|
|
|||
| - name: Trigger a build on each BinderHub deployments in the mybinder.org federation | |||
| run: | | |||
| bash scripts/trigger_binder.sh https://gke.mybinder.org/build/gh/nhuet/scikit-decide/${BINDER_RELEASE_ENV_SHA1} | |||
There was a problem hiding this comment.
should not be nhuet there
|
Retesting release workflow after correction of repository name in https://github.com/nhuet/scikit-decide/actions/runs/1576990657 |
dbarbier
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to reduce the starting time for real users. Indeed,
according to the mybinder documentation, the build step occurs only the
first time the binderhub launches a jupyter session for a repo with an updated ref. Cf https://mybinder.readthedocs.io/en/latest/about/about.html#what-factors-influence-how-long-it-takes-a-binder-session-to-start
We use a script taken from https://github.com/scikit-hep/pyhf/blob/master/binder/trigger_binder.sh
to ping the endpoints of each binderhub in the mybinder.org federation.
(cf https://mybinder.readthedocs.io/en/latest/about/federation.html)
We do not need to stay connected to the binderhub for the build to go on, so the trigger step in the workflow takes less than 1' as one can see in the workflow generated by a fake release on my fork: https://github.com/nhuet/scikit-decide/runs/4505623076?check_suite_focus=true
We can see that the build has been done for the commit corresponding to the updated binder environment:
https://mybinder.org/v2/gh/nhuet/scikit-decide/a0e09be06f993f0000b4d6c4a2908f7eec3e266f
(Here you have to trust me for not having follow this link before the workflow took place :)