Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token for github-script #145

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Remove token for github-script #145

merged 1 commit into from
Dec 8, 2021

Conversation

galleon
Copy link
Contributor

@galleon galleon commented Dec 8, 2021

[All is in the title]

Copy link
Contributor

@dbarbier dbarbier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain in the commit message why this change is needed

  TOKENs can be stored as secrets in GitHub. As such token can have limited scope
  it is better to used the default token created automatically at the start of the
  workflow to avoid issues. The token's permissions are limited to the repository
  that contains your workflow which is sufficient in our case.
@galleon galleon merged commit 4f16555 into airbus:master Dec 8, 2021
@galleon galleon deleted the gal/remove_token_for_nightly branch December 8, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants