-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test notebooks locally #137
Conversation
nhuet
commented
Dec 6, 2021
- Add nbmake in dev dependencies for testing notebooks locally with pytest
- Add explanation in contributing guide.
To test the PR, you have to install again with poetry (i do not know how to update the poetry install cleanly). And then type |
I see that the workflow crashed but is again a seg fault for tests/solvers/cpp that happens from time to time with ubuntu or macos runners (here ubuntu). It would be nice to find out why this is happening. And if someone with the proper rights (@galleon ?) can relaunch the workflow, it should work normally... (it worked on my branch that this PR is pulling: https://github.com/nhuet/scikit-decide/actions/runs/1544104432) |
Thanks @galleon ! So now that the workflow passed, what is missing for the merge ? |
Still need to move |
Weird I was sure to have added it to dev section... I move it in pyproject.toml then reinstall everything (:cry:) so that poetry.lock update accordingly and i repush... |
e77d3a9
to
ef86925
Compare
ef86925
to
7e74454
Compare
I am not sure if I am doing it properly. To add a dependency while having a poetry.lock, I
=> it results in all versions of dependencies being recomputed and updated to newest available (not necessarily what we wanted). Maybe I could have first done a Anyway, it should work like that, let us see what the workflow give us after this update... |
The poetry.lock file result from - having modified pyproject.toml to add nbmake as dev dependency - `poetry update`
7e74454
to
e1ebda8
Compare