Update notebook's kernel name and display name for default one (python3) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this change needed? Please explain in the commit message what issue it solves. |
7254f6f to
6e3c71b
Compare
The current chosen kernel name (cinb_env) was specific to my configuration and it will be not found on a generic computer. It results to - a popup message asking for choosing the appropriate kernel when running locally (so not completely an error but still unsatisfactory) - an error when testing the notebook with tool like nbmake with `pytest --nbmake`
6e3c71b to
14d09e7
Compare
|
Commit message and PR updated with the appropriate info. |
dbarbier
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current chosen kernel name (cinb_env) was specific to my configuration and it will be not found on a generic computer.
It results to
pytest --nbmakeWe may want to add a pre-commit hook to check that later.