Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiate a contribute page to online documentation #116

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Nov 22, 2021

  • a link is available in top-left menu
  • it give info about
    • installation from source in dev mode
    • local build of the docs
    • notebooks convention to extract title and description
    • unit tests

For now, it still misses guidelines about how to actually contribute.
So next steps (for further PRs) could be

  • include info from CONTRIBUTING.md in root directory, that then could point to online doc
  • update code style convention by adding how to use pre-commit to lint the code

@galleon
Copy link
Contributor

galleon commented Nov 22, 2021

I think it is a good idea to have named it contribute. It might therefore be the opportunity to describe briefly the various tools that are run of a PR and describe what are the best practices to run some of those tools locally before committing. What do you think ?

1 similar comment
@galleon
Copy link
Contributor

galleon commented Nov 22, 2021

I think it is a good idea to have named it contribute. It might therefore be the opportunity to describe briefly the various tools that are run of a PR and describe what are the best practices to run some of those tools locally before committing. What do you think ?

@nhuet
Copy link
Contributor Author

nhuet commented Nov 22, 2021

Exactly, that's the idea. Even though it is not yet the case, we should add later stuff about good practice for PRs.

@nhuet nhuet force-pushed the nh/doc_contribute_page branch from 7634f3c to de6dc1d Compare November 23, 2021 09:11
@galleon
Copy link
Contributor

galleon commented Nov 25, 2021

Can you please add a preview ? I think adding a part on how to check code with linters locally is a must since we have it now. @dbarbier can you please add something ?

@dbarbier
Copy link
Contributor

I think adding a part on how to check code with linters locally is a must since we have it now. @dbarbier can you please add something ?

It will be simpler for me to make a PR after this one is merged.

- a link is available in top-left menu
- it give info about
  - installation from source in dev mode
  - local build of the docs
  - notebooks convention to extract title and description
  - unit tests

- it still misses guidelines about how to actually contribute
@nhuet nhuet force-pushed the nh/doc_contribute_page branch from de6dc1d to d3aef9a Compare November 25, 2021 09:10
@nhuet
Copy link
Contributor Author

nhuet commented Nov 25, 2021

Can you please add a preview ?

You mean a screenshot of resulting doc ? Here you are:

Screenshot from 2021-11-25 10-16-30

For full doc, download the artifact named "doc" from the workflow triggered by this PR, then

mkdir testdoc
cd testdoc
unzip path/to/doc.zip -d scikit-decide
python -m http.server

@nhuet
Copy link
Contributor Author

nhuet commented Nov 25, 2021

I proposed a more complete contributing guide in #123 . This includes a section about code linters. If the PR #123 suits you, we can drop this one.

@galleon galleon merged commit 1198c13 into airbus:master Nov 25, 2021
@nhuet nhuet deleted the nh/doc_contribute_page branch November 26, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants