Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing multiple problems in doc #115

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Fixing multiple problems in doc #115

merged 3 commits into from
Nov 29, 2021

Conversation

galleon
Copy link
Contributor

@galleon galleon commented Nov 21, 2021

  • typo in workflow
  • re-instating version tag in navbar
  • typo in name of default branch

dbarbier
dbarbier reviewed Nov 21, 2021
View reviewed changes
Copy link
Contributor

@dbarbier dbarbier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message of b508bca is misleading, it seems to imply that there is a bug to fix, but this is not the case. This code works with any label; you can change "main" to "master" if you want, but this is cosmetics.

@dbarbier dbarbier mentioned this pull request Nov 21, 2021
Closed
@dbarbier
Copy link
Contributor

In fact it would be better to drop the "token" option of deploy, it is useless and may break if there is an error in secrets.

@dbarbier
Copy link
Contributor

You may also drop "tokem" from release.yml ;-)

@galleon
Copy link
Contributor Author

galleon commented Nov 24, 2021

You may also drop "tokem" from release.yml ;-)

Oops :-) Fixed

@dbarbier
Copy link
Contributor

Looks good.

@galleon galleon merged commit 6cab86d into airbus:master Nov 29, 2021
@galleon galleon deleted the gal/fix_doc branch December 15, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarbier dbarbier dbarbier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galleon @dbarbier