Fix scale options in xychart #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 459497485
💛 - Coveralls |
williaster
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
@Janpot thanks for the bug report and fix 🙏 ❤️
I encountered this myself before the holidays but didn't quite have time to submit a fix, this LGTM 🎉
| xScale.domain(xScaleConfig.domain || xDomain); | ||
| let xScale = createScale({ | ||
| range: [xMin, xMax], | ||
| domain: xDomain as [number, number], |
There was a problem hiding this comment.
I think depending on scale type this won't always be a number, but I can try to fix the typing in a followup PR as types can be tricky to debug here.
Pull Request Test Coverage Report for Build 459497485Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Fixes scale options not applying in
XYChart. See #986zero,nice,... options are applied increateScale. they were overwritten by setting thedomainandrangeafterwards. this PR makes sure thedomainandrangeare set in thecreateScalecall directly so that other options are applied in the correct order.