Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(xychart): expose curve types #899

Merged
merged 2 commits into from
Nov 3, 2020
Merged

new(xychart): expose curve types #899

merged 2 commits into from
Nov 3, 2020

Conversation

williaster
Copy link
Collaborator

🚀 Enhancements

This PR

  • exposes the curve line interpolation prop in BaseAreaSeries + BaseLineSeries
  • adds curve controls to the /xychart demo to illustrate + test that interpolation works correctly

This is very addicting to play with

@kristw @techniq

@williaster williaster added this to the 1.1.1 milestone Oct 28, 2020
@williaster williaster requested a review from kristw October 28, 2020 03:47
@williaster williaster force-pushed the chris--xychart-curve-types branch 3 times, most recently from e3fd37f to 27964c5 Compare October 28, 2020 19:23
@coveralls
Copy link

coveralls commented Oct 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 344440182

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.095%
Totals Coverage Status
Change from base Build 344436174: 0.0%
Covered Lines: 1549
Relevant Lines: 2445
💛 - Coveralls

Base automatically changed from chris--xychart-horizontal-context to master November 3, 2020 22:07
@williaster williaster force-pushed the chris--xychart-curve-types branch from 27964c5 to 86a7110 Compare November 3, 2020 22:10
@williaster williaster merged commit 5a638ad into master Nov 3, 2020
@williaster williaster deleted the chris--xychart-curve-types branch November 3, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

@kristw kristw Awaiting requested review from kristw

Assignees
No one assigned
Labels
🚀enhancement @visx/xychart
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@williaster @coveralls @hshoff