build: bump @types/d3-scale

[kristw]

🚀 Enhancements

• bump @types/d3-scale

Fix #855

[coveralls]

Pull Request Test Coverage Report for Build 141

Details

• 9 of 13 (69.23%) changed or added relevant lines in 2 files are covered.
• 18 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.6%) to 57.315%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/visx-stats/src/ViolinPlot.tsx	4	8	50.0%

Files with Coverage Reduction	New Missed Lines	%
packages/visx-tooltip/src/hooks/useTooltip.ts	3	44.44%
packages/visx-xychart/src/components/Tooltip.tsx	3	82.96%
packages/visx-xychart/src/components/series/LineSeries.tsx	5	40.63%
packages/visx-tooltip/src/hooks/useTooltipInPortal.tsx	7	0.0%

Totals
Change from base Build 119:	0.6%
Covered Lines:	1285
Relevant Lines:	2172

---

💛 - Coveralls

[williaster]

thanks for making all the fixes needed for this 🙏 lgtm. may have to figure out if this will count as a breaking change or not.

[razh]

Might be able to revert this? @types/d3-scale v3.2.1 no longer returns unknown values.

DefinitelyTyped/DefinitelyTyped#49196

[williaster]

@kristw wdyt?

[kristw]

Might be able to revert this? @types/d3-scale v3.2.1 no longer returns unknown values.

DefinitelyTyped/DefinitelyTyped#49196

@razh Could you elaborate a bit more about your concerns with the unknown and why we should revert the change?

Also, things are a bit more complicated as the previous version of the types was for d3-scale 2 and mistyped a few things and did not include several functions that are available API. I would prefer to have types that better match the d3-scale to avoid mistakes in the library.

[razh]

It's mostly a matter of correctness versus convenience.

Given a known domain and range, scaleLinear/scaleTime/etc. should not return undefined.

This comment explains the rationale:

DefinitelyTyped/DefinitelyTyped#48299 (comment)

I don't have a stake in the game here, just FYI!