new(workflows/push): automate releases #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Pull Request has a valid release label.
65e23e3 to
683e180
Compare
52e4620 to
b345221
Compare
williaster
commented
Mar 1, 2021
| // perform release | ||
| try { | ||
| const version = `${isPreRelease ? 'pre' : ''}${ | ||
| isMajor ? 'major' : isMinor ? 'minor' : 'patch' |
There was a problem hiding this comment.
if only alpha-release is set, this will default to patch which I think is safe
williaster
commented
Mar 1, 2021
| run: | | ||
| yarn build:sizes | ||
| git config user.name github-actions | ||
| git config user.email github-actions@github.com | ||
| git add . | ||
| git commit -m "build(${GITHUB_SHA}): auto-commit package sizes" | ||
| git diff-index --quiet HEAD || git commit -m "build(${GITHUB_SHA}): auto-commit package sizes" |
There was a problem hiding this comment.
if there were no package size changes, this was failing before
williaster
commented
Mar 1, 2021
scripts/performRelease/updateChangelog/mergeUpdateIntoChangelog.ts
Outdated
Show resolved
Hide resolved
kristw
approved these changes
Mar 5, 2021
|
🎉 This PR is included in version |
This was referenced Mar 15, 2021
This was referenced Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This PR adds automated releases to the github
pushworkflow (i.e., merges intomaster). I wrote most everything custom because I couldn't find anything compelling for both the automated release + changelog updates without also adopting conventional commits which I think would be tricky. Npm auth with lerna was tricky 🥴 .In the future the release cycle would work like the following:
patch-release,minor-release,major-release,alpha-release), nothing will happengithub-botposts on all PRs since the last release informing the author(s) which version the PR was released asI tested this as much as I could on a branch, so hopefully it will go smootly upon merge.
Example commits
Example changelog diff
Example posting on PRs
@kristw @hshoff